linux-kernel - Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 10:39:51 +0100
From:	Suzuki K Poulose <Suzuki.Poulose@....com>
To:	fu.wei@...aro.org, tn@...ihalf.com, rjw@...ysocki.net,
	len.brown@...el.com, pavel@....cz, catalin.marinas@....com,
	will.deacon@....com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	x86@...nel.org, linaro-acpi@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
	graeme.gregory@...aro.org, al.stone@...aro.org,
	hanjun.guo@...aro.org, mark.rutland@....com, Marc.Zyngier@....com,
	lorenzo.pieralisi@....com, rruigrok@...eaurora.org,
	harba@....qualcomm.com, tbaicar@...eaurora.org, jcm@...hat.com,
	msalter@...hat.com, grant.likely@...aro.org, rrichter@...ium.com,
	jarkko.nikula@...ux.intel.com, jon.zhixiong.zhang@...il.com,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>
Subject: Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64.

On 27/07/16 18:29, fu.wei@...aro.org wrote:
> From: Tomasz Nowicki <tomasz.nowicki@...aro.org>
>
> This commit provides APEI arch-specific bits for aarch64
>
> Meanwhile,
> (1)add a new subfunction "hest_ia32_init" for
> "acpi_disable_cmcff" which is used by IA-32 Architecture
> Corrected Machine Check (CMC).
> (2)move HEST type (ACPI_HEST_TYPE_IA32_CORRECTED_CHECK) checking to
> a generic place.
> (3)select HAVE_ACPI_APEI when EFI and ACPI is set on ARM64,
> because arch_apei_get_mem_attribute is using efi_mem_attributes on ARM64.
>
> [Fu Wei: improve && upstream]
>


> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
> index 5420cb0..d3d02dc 100644
> --- a/arch/arm64/include/asm/acpi.h
> +++ b/arch/arm64/include/asm/acpi.h
> @@ -17,6 +17,7 @@
>
>  #include <asm/cputype.h>
>  #include <asm/smp_plat.h>
> +#include <asm/tlbflush.h>
>
>  /* Macros for consistency checks of the GICC subtable of MADT */
>  #define ACPI_MADT_GICC_LENGTH	\
> @@ -110,8 +111,21 @@ static inline const char *acpi_get_enable_method(int cpu)
>  }
>
>  #ifdef	CONFIG_ACPI_APEI
> +#define acpi_disable_cmcff 1
>  pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
> -#endif
> +
> +/*
> + * Despite its name, this function must still broadcast the TLB
> + * invalidation in order to ensure other CPUs don't up with with junk

Please fix the comment above ^^^.


Suzuki