linux-kernel - Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()

Open Source and information security mailing list archives

Message-ID: <20160728110018.GK6232@phenom.ffwll.local>
Date:	Thu, 28 Jul 2016 13:00:18 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Brian Starkey <brian.starkey@....com>
Cc:	Wei Yongjun <weiyj.lk@...il.com>, seanpaul@...omium.org,
	Liviu Dudau <liviu.dudau@....com>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in
 malidp_bind()

On Thu, Jul 28, 2016 at 09:22:21AM +0100, Brian Starkey wrote:
> Hi Wei,
> 
> On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
> > Fix to return error code -EINVAL from the error handling
> > case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
> > instead of the endpoint')
> > Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
> > ---
> 
> Thanks for cleaning up after me! :-)
> 
> Acked-by: Brian Starkey <brian.starkey@....com>

Applied to drm-misc, thanks.
-Daniel

> 
> @Sean, can you pick this up on top of 3c31760e760c?
> 
> Cheers,
> Brian
> 
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..44b24cb 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
> > 
> > 	/* Set the CRTC's port so that the encoder component can find it */
> > 	ep = of_graph_get_next_endpoint(dev->of_node, NULL);
> > -	if (!ep)
> > +	if (!ep) {
> > +		ret = -EINVAL;
> > 		goto port_fail;
> > +	}
> > 	malidp->crtc.port = of_get_next_parent(ep);
> > 
> > 	ret = component_bind_all(dev, drm);
> > 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives