linux-kernel - [PATCH -next] iommu/amd: Fix error return code in irq_remapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1469671826-13144-1-git-send-email-weiyj.lk@gmail.com>
Date:	Thu, 28 Jul 2016 02:10:26 +0000
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Wei Yongjun <weiyj.lk@...il.com>, iommu@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()

Fix to return a negative error code from the alloc_irq_index() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
---
 drivers/iommu/amd_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 96de97a..71e94f3 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3886,6 +3886,7 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,
 	}
 	if (index < 0) {
 		pr_warn("Failed to allocate IRTE\n");
+		ret = index;
 		goto out_free_parent;
 	}