linux-kernel - Re: [PATCH 13/15] perf script python: Fix string vs byte array resolving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160728144215.3c62b0a0@gandalf.local.home>
Date:	Thu, 28 Jul 2016 14:42:15 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Jiri Olsa <jolsa@...nel.org>, David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 13/15] perf script python: Fix string vs byte array
 resolving

On Mon, 18 Jul 2016 20:33:16 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> From: Jiri Olsa <jolsa@...nel.org>
> 
> Jirka reported that python code returns all arrays as strings.  This
> makes impossible to get all items for byte array tracepoint field
> containing 0x00 value item.
> 
> Fixing this by scanning full length of the array and returning it as
> PyByteArray object in case non printable byte is found.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Reported-and-Tested-by: Jiri Pirko <jiri@...lanox.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Link: http://lkml.kernel.org/r/1468685480-18951-2-git-send-email-jolsa@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  .../util/scripting-engines/trace-event-python.c    | 39 ++++++++++++++++++----
>  1 file changed, 33 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
> index 6ac6b7a33f42..7bd6da80533e 100644
> --- a/tools/perf/util/scripting-engines/trace-event-python.c
> +++ b/tools/perf/util/scripting-engines/trace-event-python.c
> @@ -386,6 +386,21 @@ exit:
>  	return pylist;
>  }
>  
> +static int is_printable_array(char *p, unsigned int len)
> +{
> +	unsigned int i;
> +
> +	if (!p || !len || p[len - 1] != 0)
> +		return 0;
> +
> +	len--;
> +
> +	for (i = 0; i < len; i++) {
> +		if (!isprint(p[i]) && !isspace(p[i]))
> +			return 0;
> +	}
> +	return 1;
> +}
>  

Darn, I never got to add my Reviewed-by tag, as I had lots of comments
on this function. Oh well, that's what happens when you go off to
volcanoes.

-- Steve