linux-kernel - Re: [PATCH] Input - elantech: fix debug dump of the current packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69E215A7-E962-47FB-8735-208972CBAA65@gmail.com>
Date:	Thu, 28 Jul 2016 12:03:33 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input - elantech: fix debug dump of the current packet

On July 28, 2016 11:58:29 AM PDT, Joe Perches <joe@...ches.com> wrote:
>On Thu, 2016-07-28 at 11:54 -0700, Dmitry Torokhov wrote:
>> On Thu, Jul 28, 2016 at 11:49:57AM -0700, Joe Perches wrote:
>[]
>> > So use dev_printk(KERN_DEBUG, etc...
>> #define psmouse_printk(level, psmouse, format, ...)	\
>> 	dev_printk(level,				\
>> 		   &(psmouse)->ps2dev.serio->dev,	\
>> 		   psmouse_fmt(format), ##__VA_ARGS__)
>> 
>> I want to see current protocol module in th eoutput and I do not want
>to
>> write "&(psmouse)->ps2dev.serio->dev" all the time.
>
>There are only 2 uses of the macro.
>
>$ git grep psmouse_printk
>drivers/input/mouse/elantech.c:                 psmouse_printk(KERN_DEBUG,
>psmouse,             \
>drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse,
>"PS/2 packet [");
>drivers/input/mouse/psmouse.h:#define psmouse_printk(level, psmouse,
>format, ...)       \

Yes, but many more of psmouse_<severity> calls and I like consistency.


Thanks.

-- 
Dmitry