linux-kernel - tasklet_kill makes sure no future re-schedule?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 12:52:17 -0700
From:	Wengang <wen.gang.wang@...cle.com>
To:	linux-kernel@...r.kernel.org
Cc:	Wengang Wang <wen.gang.wang@...cle.com>,
	Santosh Shilimkar <santosh.shilimkar@...cle.com>,
	Srinivas Eeda <srinivas.eeda@...cle.com>
Subject: tasklet_kill makes sure no future re-schedule?

Hi,

I recently hit an issue that after tasklet_kill called against a tasket, 
the tasklet can still be scheduled in IRQ context and run at a later time.
So my question is whether tasklet_kill is designed to make sure no 
future re-scheduling can be done. I didn't find an official document 
stating that, but find some non-official ones. The thing is that the 
voices are different:

Someone (http://www.makelinux.net/books/lkd2/ch07lev1sec3) says

"You can remove a tasklet from the pending queue via tasklet_kill(). 
This function receives a pointer as a lone argument to the tasklet's 
tasklet_struct. Removing a scheduled tasklet from the queue is useful 
when dealing with a tasklet that often reschedules itself. This function 
first waits for the tasklet to finish executing and then it removes the 
tasklet from the queue. Nothing stops some other code from rescheduling 
the tasklet, of course. This function must not be used from interrupt 
context because it sleeps."

And someone else (http://www.makelinux.net/ldd3/chp-7-sect-5) says

"This function ensures that the tasklet is not scheduled to run again; 
it is usually called when a device is being closed or the module 
removed. If the tasklet is scheduled to run, the function waits until it 
has executed. If the tasklet reschedules itself, you must prevent it 
from rescheduling itself before calling tasklet_kill, as with 
del_timer_sync."

Looking at the code, I prefer "Nothing stops some other code from 
rescheduling the lasklet". But I want a confirm here please!

Thanks,
Wengang