linux-kernel - Re: [linux-sunxi] [PATCH] regulator: axp20x: support AXP813 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 22:21:18 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Julian Calaby <julian.calaby@...il.com>
Cc:	moinejf@...e.fr, Chen-Yu Tsai <wens@...e.org>,
	"Mailing List, Arm" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [linux-sunxi] [PATCH] regulator: axp20x: support AXP813 variant

On Thu, Jul 28, 2016 at 08:24:41PM +1000, Julian Calaby wrote:
> Hi All,
> 
> On Thu, Jul 28, 2016 at 5:28 PM, Jean-Francois Moine <moinejf@...e.fr> wrote:
> > The X-Powers AXP813 PMIC is close enough to the AXP809 with some
> > more outputs.
> >
> > Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>
> > ---
> >  Documentation/devicetree/bindings/mfd/axp20x.txt | 32 ++++++++-
> >  drivers/mfd/axp20x-rsb.c                         |  1 +
> >  drivers/mfd/axp20x.c                             |  3 +
> >  drivers/regulator/axp20x-regulator.c             | 82 +++++++++++++++++++++++-
> >  include/linux/mfd/axp20x.h                       | 38 +++++++++++
> >  5 files changed, 153 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> > index 6d9ac76..c3287c9 100644
> > --- a/drivers/regulator/axp20x-regulator.c
> > +++ b/drivers/regulator/axp20x-regulator.c
> > @@ -467,7 +543,8 @@ static int axp20x_regulator_probe(struct platform_device *pdev)
> >                  * name.
> >                  */
> >                 if ((regulators == axp22x_regulators && i == AXP22X_DC1SW) ||
> > -                   (regulators == axp809_regulators && i == AXP809_DC1SW)) {
> > +                   (regulators == axp809_regulators && i == AXP809_DC1SW) ||
> > +                   (regulators == axp813_regulators && i == AXP813_DC1SW)) {
> 
> Are we getting to the point now where we need some other way to flag
> these? Maybe a set of flags per regulator?

I'd be inclined to say yes. We can also associate a structure to the
compatible, and store a bunch of infos there (like does it have a
DC1SW regulator in this case).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)