linux-kernel - Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <579A6DCC.6060401@metafoo.de>
Date:	Thu, 28 Jul 2016 22:40:44 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Nicolin Chen <nicoleotsuka@...il.com>, broonie@...nel.org
Cc:	mark.rutland@....com, oder_chiou@...ltek.com,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, bardliao@...ltek.com
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls

> +	/* Check if MCLK provided */
> +	rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(rt5659->mclk)) {
> +		if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;

The correct thing to do here is to check if != -ENOENT and then return
the error code. Otherwise you silently ignore errors if a clock was
specified, but there was an error requesting it.