linux-kernel - Re: [PATCH] cxl: replace loop with for_each_child_of_node(), remove unneeded of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ccadf7cc-6b10-1559-9c7a-23e28d4a4d51@linux.vnet.ibm.com>
Date:	Fri, 29 Jul 2016 09:43:22 +0200
From:	Frederic Barrat <fbarrat@...ux.vnet.ibm.com>
To:	Andrew Donnellan <andrew.donnellan@....ibm.com>,
	linuxppc-dev@...ts.ozlabs.org
Cc:	imunsie@....ibm.com, clombard@...ux.vnet.ibm.com,
	kernel-janitors@...r.kernel.org, elfring@...rs.sourceforge.net,
	julia.lawall@...6.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl: replace loop with for_each_child_of_node(), remove
 unneeded of_node_put()


Le 29/07/2016 à 05:55, Andrew Donnellan a écrit :
> Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use
> for_each_child_of_node() rather than a hand-coded for loop.
>
> Remove the useless of_node_put(afu_np) call after the loop, where it's
> guaranteed that afu_np == NULL.
>
> Reported-by: SF Markus Elfring <elfring@...rs.sourceforge.net>
> Reported-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>


Thanks!

Reviewed-by: Frederic Barrat <fbarrat@...ux.vnet.ibm.com>