linux-kernel - Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87oa5gsu8d.fsf@vitty.brq.redhat.com>
Date:	Fri, 29 Jul 2016 10:50:58 +0200
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	David Vrabel <david.vrabel@...rix.com>
Cc:	<xen-devel@...ts.xenproject.org>, Juergen Gross <jgross@...e.com>,
	Stefano Stabellini <sstabellini@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Julien Grall <julien.grall@....com>,
	"Boris Ostrovsky" <boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to uint32_t

David Vrabel <david.vrabel@...rix.com> writes:

> On 28/07/16 17:24, Vitaly Kuznetsov wrote:
>> We pass xen_vcpu_id mapping information to hypercalls which require
>> uint32_t type so it would be cleaner to have it as uint32_t. The
>> initializer to -1 can be dropped as we always do the mapping before using
>> it and we never check the 'not set' value anyway.
> [...]
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -9,7 +9,7 @@
>>  
>>  DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>>  
>> -DECLARE_PER_CPU(int, xen_vcpu_id);
>> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
>>  static inline int xen_vcpu_nr(int cpu)
>
> Should the return type of this change to uint32_t as well?
>

Yes, missed that, will do v2. Sorry!

>>  {
>>  	return per_cpu(xen_vcpu_id, cpu);
>> 

-- 
  Vitaly