linux-kernel - [PATCH 1/2] drm: mali-dp: Clear the config_valid flag before using it in wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160729144416.2860-2-Liviu.Dudau@arm.com>
Date:	Fri, 29 Jul 2016 15:44:15 +0100
From:	Liviu Dudau <Liviu.Dudau@....com>
To:	David Airlie <airlied@...ux.ie>,
	Mali DP Maintainers <malidp@...s.arm.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>
Cc:	DRI devel <dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Brian Starkey <Brian.Starkey@....com>
Subject: [PATCH 1/2] drm: mali-dp: Clear the config_valid flag before using it in wait_event.

config_valid variable is used to signal the activation of the CVAL
request when the vsync interrupt has fired. malidp_set_and_wait_config_valid()
uses the variable in wait_event_interruptible_timeout without clearing it
first, so the wait is skipped.

Cc: Brian Starkey <Brian.Starkey@....com>
Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>
---
 drivers/gpu/drm/arm/malidp_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 82171d2..87c9249 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -42,6 +42,7 @@ static int malidp_set_and_wait_config_valid(struct drm_device *drm)
 	struct malidp_hw_device *hwdev = malidp->dev;
 	int ret;
 
+	atomic_set(&malidp->config_valid, 0);
 	hwdev->set_config_valid(hwdev);
 	/* don't wait for config_valid flag if we are in config mode */
 	if (hwdev->in_config_mode(hwdev))
-- 
2.9.0