linux-kernel - Re: [PATCH] checkpatch: check signoff when reading stdin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1469806721.3998.80.camel@perches.com>
Date:	Fri, 29 Jul 2016 08:38:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Allen Hubbe <allenbh@...il.com>
Cc:	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] checkpatch: check signoff when reading stdin

On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote:
> On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches <joe@...ches.com> wrote:
> > 
> > I think this is not a great idea because the most likely
> > use case is piping git diff output ala:
> > 
> > $ git diff <some_path> | ./scripts/checkpatch.pl -
> Thanks for the review.  Has v2 addressed your concern?

Hi Allen.

For the most part, yes, your V2 works better.

I was wondering if the - should be optional and thinking
$ git diff <some-path> | ./scripts/checkpatch.pl
should work the same way, but I guess that can wait for
another day, so

Acked-by: Joe Perches <joe@...ches.com>

cheers, Joe