linux-kernel - Re: [PATCH] regmap: cache: Fix num_reg_defaults computation from reg_defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2016 17:42:21 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Maarten ter Huurne <maarten@...ewalker.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: cache: Fix num_reg_defaults computation from
 reg_defaults_raw

On Fri, Jul 29, 2016 at 04:46:43PM +0200, Maarten ter Huurne wrote:

>  	for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++)
> -		if (!regmap_volatile(map, i * map->reg_stride))
> +		if (regmap_readable(map, i * map->reg_stride) &&
> +				!regmap_volatile(map, i * map->reg_stride))

This seems fine but please use a normal coding style, there's a *huge*
amount of indentation on the second line for some reason.  It should
align with the ( in the if statement.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)