lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201607300416.0YXxtvUw%fengguang.wu@intel.com>
Date:	Sat, 30 Jul 2016 04:01:37 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	kbuild-all@...org, Stephen Just <stephenjust@...il.com>,
	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-acpi@...r.kernel.org, devel@...ica.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] power: surface3_power: MSHW0011 rev-eng
 implementation

Hi,

[auto build test WARNING on battery/master]
[also build test WARNING on v4.7 next-20160729]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Tissoires/Add-support-for-Microsoft-Surface-3-power/20160729-235348
base:   git://git.infradead.org/battery-2.6.git master
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   drivers/power/surface3_power.c:52:52: error: expected ')' before 'bool'
    module_param_named(dump_registers, dump_registers, bool, 0644);
                                                       ^
   drivers/power/surface3_power.c:54:4: error: expected ')' before string constant
       "Dump the SMBus register at probe (debugging only).");
       ^
   drivers/power/surface3_power.c: In function 'mshw0011_notify':
   drivers/power/surface3_power.c:199:17: error: implicit declaration of function 'acpi_bus_get_device' [-Werror=implicit-function-declaration]
     if (!handle || acpi_bus_get_device(handle, &adev))
                    ^
   drivers/power/surface3_power.c:202:8: error: implicit declaration of function 'acpi_evaluate_dsm_typed' [-Werror=implicit-function-declaration]
     obj = acpi_evaluate_dsm_typed(handle, mshw0011_guid, arg1, arg2, NULL,
           ^
   drivers/power/surface3_power.c:202:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     obj = acpi_evaluate_dsm_typed(handle, mshw0011_guid, arg1, arg2, NULL,
         ^
   drivers/power/surface3_power.c: In function 'mshw0011_space_handler':
   drivers/power/surface3_power.c:441:23: error: 'ACPI_GSB_ACCESS_ATTRIB_RAW_PROCESS' undeclared (first use in this function)
     if (accessor_type != ACPI_GSB_ACCESS_ATTRIB_RAW_PROCESS) {
                          ^
   drivers/power/surface3_power.c:441:23: note: each undeclared identifier is reported only once for each function it appears in
   drivers/power/surface3_power.c: In function 'mshw0011_install_space_handler':
   drivers/power/surface3_power.c:511:11: error: implicit declaration of function 'acpi_bus_attach_private_data' [-Werror=implicit-function-declaration]
     status = acpi_bus_attach_private_data(handle, (void *)data);
              ^
   drivers/power/surface3_power.c:524:3: error: implicit declaration of function 'acpi_bus_detach_private_data' [-Werror=implicit-function-declaration]
      acpi_bus_detach_private_data(handle);
      ^
   drivers/power/surface3_power.c:529:2: error: implicit declaration of function 'acpi_walk_dep_device_list' [-Werror=implicit-function-declaration]
     acpi_walk_dep_device_list(handle);
     ^
   drivers/power/surface3_power.c: In function 'mshw0011_remove_space_handler':
   drivers/power/surface3_power.c:548:11: error: implicit declaration of function 'acpi_bus_get_private_data' [-Werror=implicit-function-declaration]
     status = acpi_bus_get_private_data(handle, (void **)&data);
              ^
   drivers/power/surface3_power.c: In function 'mshw0011_i2c_resource_lookup':
   drivers/power/surface3_power.c:582:8: error: implicit declaration of function 'acpi_dev_get_resources' [-Werror=implicit-function-declaration]
     ret = acpi_dev_get_resources(adev, &res_list, acpi_find_i2c, &lookup);
           ^
   drivers/power/surface3_power.c:586:2: error: implicit declaration of function 'acpi_dev_free_resource_list' [-Werror=implicit-function-declaration]
     acpi_dev_free_resource_list(&res_list);
     ^
   drivers/power/surface3_power.c:571:21: warning: unused variable 'client' [-Wunused-variable]
     struct i2c_client *client = cdata->adp1;
                        ^
   drivers/power/surface3_power.c: At top level:
   drivers/power/surface3_power.c:701:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(i2c, mshw0011_id);
    ^
   drivers/power/surface3_power.c:701:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
   drivers/power/surface3_power.c:701:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/i2c.h:30:0,
                    from drivers/power/surface3_power.c:41:
   include/linux/device.h:1350:1: warning: data definition has no type or storage class
    module_init(__driver##_init); \
    ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   include/linux/device.h:1350:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
    module_init(__driver##_init); \
    ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   In file included from include/linux/linkage.h:6:0,
                    from include/linux/kernel.h:6,
                    from drivers/power/surface3_power.c:40:
>> include/linux/export.h:36:30: warning: parameter names (without types) in function declaration
    #define THIS_MODULE ((struct module *)0)
                                 ^
>> include/linux/i2c.h:651:22: note: in expansion of macro 'THIS_MODULE'
     i2c_register_driver(THIS_MODULE, driver)
                         ^
>> include/linux/device.h:1348:9: note: in expansion of macro 'i2c_add_driver'
     return __register(&(__driver) , ##__VA_ARGS__); \
            ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   In file included from include/linux/i2c.h:30:0,
                    from drivers/power/surface3_power.c:41:
   include/linux/device.h:1355:1: warning: data definition has no type or storage class
    module_exit(__driver##_exit);
    ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   include/linux/device.h:1355:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
    module_exit(__driver##_exit);
    ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   In file included from include/linux/linkage.h:6:0,
                    from include/linux/kernel.h:6,
                    from drivers/power/surface3_power.c:40:
>> include/linux/export.h:36:30: warning: parameter names (without types) in function declaration
    #define THIS_MODULE ((struct module *)0)
                                 ^
>> include/linux/i2c.h:651:22: note: in expansion of macro 'THIS_MODULE'
     i2c_register_driver(THIS_MODULE, driver)
                         ^
>> include/linux/device.h:1348:9: note: in expansion of macro 'i2c_add_driver'
     return __register(&(__driver) , ##__VA_ARGS__); \
            ^
   include/linux/i2c.h:712:2: note: in expansion of macro 'module_driver'
     module_driver(__i2c_driver, i2c_add_driver, \
     ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   drivers/power/surface3_power.c:722:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@...il.com>");
                  ^
   drivers/power/surface3_power.c:723:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("mshw0011 driver");
                       ^
   drivers/power/surface3_power.c:724:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL v2");
                   ^
   In file included from include/linux/i2c.h:30:0,
                    from drivers/power/surface3_power.c:41:
   drivers/power/surface3_power.c:720:19: warning: 'mshw0011_driver_init' defined but not used [-Wunused-function]
    module_i2c_driver(mshw0011_driver);
                      ^
   include/linux/device.h:1346:19: note: in definition of macro 'module_driver'
    static int __init __driver##_init(void) \
                      ^
   drivers/power/surface3_power.c:720:1: note: in expansion of macro 'module_i2c_driver'
    module_i2c_driver(mshw0011_driver);
    ^
   cc1: some warnings being treated as errors

vim +/THIS_MODULE +651 include/linux/i2c.h

c7036673 Hans Verkuil       2009-06-19  635  
^1da177e Linus Torvalds     2005-04-16  636  
^1da177e Linus Torvalds     2005-04-16  637  /* ----- functions exported by i2c.o */
^1da177e Linus Torvalds     2005-04-16  638  
^1da177e Linus Torvalds     2005-04-16  639  /* administration...
^1da177e Linus Torvalds     2005-04-16  640   */
23af8400 Jean Delvare       2009-06-19  641  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
^1da177e Linus Torvalds     2005-04-16  642  extern int i2c_add_adapter(struct i2c_adapter *);
71546300 Lars-Peter Clausen 2013-03-09  643  extern void i2c_del_adapter(struct i2c_adapter *);
6e13e641 David Brownell     2007-05-01  644  extern int i2c_add_numbered_adapter(struct i2c_adapter *);
^1da177e Linus Torvalds     2005-04-16  645  
de59cf9e Greg Kroah-Hartman 2005-12-06  646  extern int i2c_register_driver(struct module *, struct i2c_driver *);
b3e82096 Jean Delvare       2007-05-01  647  extern void i2c_del_driver(struct i2c_driver *);
^1da177e Linus Torvalds     2005-04-16  648  
eb5589a8 Paul Gortmaker     2011-05-27  649  /* use a define to avoid include chaining to get THIS_MODULE */
eb5589a8 Paul Gortmaker     2011-05-27  650  #define i2c_add_driver(driver) \
eb5589a8 Paul Gortmaker     2011-05-27 @651  	i2c_register_driver(THIS_MODULE, driver)
de59cf9e Greg Kroah-Hartman 2005-12-06  652  
e48d3319 Jean Delvare       2008-01-27  653  extern struct i2c_client *i2c_use_client(struct i2c_client *client);
e48d3319 Jean Delvare       2008-01-27  654  extern void i2c_release_client(struct i2c_client *client);
^1da177e Linus Torvalds     2005-04-16  655  
^1da177e Linus Torvalds     2005-04-16  656  /* call the i2c_client->command() of all attached clients with
^1da177e Linus Torvalds     2005-04-16  657   * the given arguments */
^1da177e Linus Torvalds     2005-04-16  658  extern void i2c_clients_command(struct i2c_adapter *adap,
^1da177e Linus Torvalds     2005-04-16  659  				unsigned int cmd, void *arg);

:::::: The code at line 651 was first introduced by commit
:::::: eb5589a8f0dab7e29021344228856339e6a1249c include: convert various register fcns to macros to avoid include chaining

:::::: TO: Paul Gortmaker <paul.gortmaker@...driver.com>
:::::: CC: Paul Gortmaker <paul.gortmaker@...driver.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (42414 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ