linux-kernel - Re: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160729140741.18ca3e35@xeon-e3>
Date:	Fri, 29 Jul 2016 14:07:41 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Amir Levy <amir.jer.levy@...el.com>
Cc:	andreas.noever@...il.com, gregkh@...uxfoundation.org,
	bhelgaas@...gle.com, corbet@....net, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, thunderbolt-linux@...el.com,
	mika.westerberg@...el.com, tomas.winkler@...el.com
Subject: Re: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Thu, 28 Jul 2016 11:15:19 +0300
Amir Levy <amir.jer.levy@...el.com> wrote:

> +		/* pad short packets */
> +		if (unlikely(skb->len < ETH_ZLEN)) {
> +			int pad_len = ETH_ZLEN - skb->len;
> +
> +			/* The skb is freed on error */
> +			if (unlikely(skb_pad(skb, pad_len))) {
> +				cleaned_count += frame_count;
> +				continue;
> +			}
> +			__skb_put(skb, pad_len);
> +		}

Packets should be padded on transmit, not on receive??