linux-kernel - RE: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2016 19:38:45 +0000
From:	"Deucher, Alexander" <Alexander.Deucher@....com>
To:	'Sean Paul' <seanpaul@...gle.com>, Wei Yongjun <weiyj.lk@...il.com>
CC:	"Koenig, Christian" <Christian.Koenig@....com>,
	Dave Airlie <airlied@...ux.ie>,
	"Jiang, Sonny" <Sonny.Jiang@....com>, "Liu, Leo" <Leo.Liu@....com>,
	"Nath, Arindam" <Arindam.Nath@....com>,
	"Zhou, David(ChunMing)" <David1.Zhou@....com>,
	"Zhou, Jammy" <Jammy.Zhou@....com>, "Liu, Monk" <Monk.Liu@....com>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its
 implementation

> -----Original Message-----
> From: Sean Paul [mailto:seanpaul@...gle.com]
> Sent: Friday, July 29, 2016 3:35 PM
> To: Wei Yongjun
> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
> Linux Kernel Mailing List
> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
> duplicating its implementation
> 
> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> > Use kmemdup rather than duplicating its implementation.
> >
> > Generated by: scripts/coccinelle/api/memdup.cocci
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
> 
> 
> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
> 
> Acked-by: Sean Paul <seanpaul@...omium.org>

Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.

Alex

> 
> 
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > index a46a64c..b779b5f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
> *adev)
> >         size = amdgpu_bo_size(adev->uvd.vcpu_bo);
> >         ptr = adev->uvd.cpu_addr;
> >
> > -       adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> > +       adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
> >         if (!adev->uvd.saved_bo)
> >                 return -ENOMEM;
> >
> > -       memcpy(adev->uvd.saved_bo, ptr, size);
> > -
> >         return 0;
> >  }
> >
> >
> >
> >