linux-kernel - Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2016 12:34:44 +0900
From:	Jaehoon Chung <jh80.chung@...sung.com>
To:	Shawn Lin <shawn.lin@...k-chips.com>, linux-mmc@...r.kernel.org
Cc:	ulf.hansson@...aro.org, linux-kernel@...r.kernel.org,
	Rob Herrin <robh+dt@...nel.org>, mark.rutland@....com,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated
 "supports-highspeed" property

Hi Shawn,

On 07/29/2016 11:44 AM, Shawn Lin wrote:
> 在 2016/7/28 17:55, Jaehoon Chung 写道:
>> Remvoe the deprecated "supports-highspeed" property.
>> DWMMC controller will not use this property anymore.
>>
> 
> We had set up a flag day to remove these deprecated property
> long time agao.
> 
> It doesn't *break* old dtb which may(not ?) still boot up new
> kernel code as we just make it suffer from lower speed, then
> I think it's time for them to migrate to the new property anyway.

Thanks for reviewing!

Best Regards,
Jaehoon Chung

> 
> So,
> 
> Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>
> 
>> Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 1b719a6..e9faedd 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>>              return ERR_PTR(ret);
>>      }
>>
>> -    if (of_find_property(np, "supports-highspeed", NULL)) {
>> -        dev_info(dev, "supports-highspeed property is deprecated.\n");
>> -        pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>> -    }
>> -
>>      return pdata;
>>  }
>>
>>
> 
>