linux-kernel - [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLUrJ86pJ20ppTycG3e2wv=zegC6UfQdXtnjeQYxQw2iMg@mail.gmail.com>
Date:	Thu, 28 Jul 2016 21:18:16 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Mateusz Bajorski <mateusz.bajorski@...ia.com>
Cc:	David Ahern <dsa@...ulusnetworks.com>,
	"David S. Miller" <davem@...emloft.net>,
	lkml <linux-kernel@...r.kernel.org>,
	Guodong Xu <guodong.xu@...aro.org>,
	Dmitry Shmidt <dimitrysh@...gle.com>
Subject: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule
 breaks Android userspace

After moving my HiKey tree to pre-v4.8-rc, I noticed when using
Android that I was getting routing errors after toggling networking on
and off (or entering suspend). Wifi associated, but I got some
rounting errors in the logcat the connection manager wouldn't detect a
valid network.

Not being able to figure out exactly what was going wrong from the
userspace side, I bisected (manually rebasing a 70 patch stack each
step :P) it down and it seems that the commit: 153380ec4b9b
("fib_rules: Added NLM_F_EXCL support to fib_nl_newrule") is causing
the problem.

Reverting that patch seems to make things work again.

I'm no networking guru, but I'm happy to help debug this further if
folks can walk me through it a bit.

thanks
-john