linux-kernel - Re: [PATCH] KEYS: Sort out big

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1469909550.3998.123.camel@perches.com>
Date:	Sat, 30 Jul 2016 13:12:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kirill Marinushkin <k.marinushkin@...il.com>, dhowells@...hat.com
Cc:	zer0mem@...oo.com, gregkh@...uxfoundation.org, serge@...lyn.com,
	james.l.morris@...cle.com, keyrings@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] KEYS: Sort out big_key initialisation

On Sat, 2016-07-30 at 22:03 +0200, Kirill Marinushkin wrote:
> big_key has two separate initialisation functions, one that registers the
> key type and one that registers the crypto.  If the key type fails to
> register, there's no problem if the crypto registers successfully because
> there's no way to reach the crypto except through the key type.

trivia:

> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -9,6 +9,7 @@
>   * 2 of the Licence, or (at your option) any later version.
>   */
>  
> +#define pr_fmt(fmt) "big_key: "fmt

It's much more common to use

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt