lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Jul 2016 08:23:04 -0400 From: Martin Schwidefsky <schwidefsky@...ibm.com> To: James Hogan <james.hogan@...tec.com> Cc: <linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Heiko Carstens <heiko.carstens@...ibm.com>, <linux-s390@...r.kernel.org> Subject: Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO On Mon, 25 Jul 2016 16:59:53 +0100 James Hogan <james.hogan@...tec.com> wrote: > AT_VECTOR_SIZE_ARCH should be defined with the maximum number of > NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined > for s390 at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when > VDSO is enabled. > > This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for > AT_BASE_PLATFORM which s390 doesn't use, but lets define it now and add > the comment above ARCH_DLINFO as found in several other architectures to > remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: b020632e40c3 ("[S390] introduce vdso on s390") > Signed-off-by: James Hogan <james.hogan@...tec.com> > Cc: Martin Schwidefsky <schwidefsky@...ibm.com> > Cc: Heiko Carstens <heiko.carstens@...ibm.com> > Cc: linux-s390@...r.kernel.org The patch makes sense. I not quite sure about the checkpoint-restore code that clears the last two entries of the user_auxv[] without knowing how many aux entries there really are. That seems kind of strange. I will the patch to our repositories and we'll give it a spin. If there is no fallout I queue it to linux-s390. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Powered by blists - more mailing lists