linux-kernel - Re: [PATCH] ubifs: Fix xattr generic handler usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 1 Aug 2016 10:51:44 +0200
From:	Andreas Grünbacher <andreas.gruenbacher@...il.com>
To:	Richard Weinberger <richard@....at>
Cc:	linux-mtd@...ts.infradead.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Artem Bityutskiy <dedekind1@...il.com>, stable@...r.kernel.org,
	Andreas Gruenbacher <agruenba@...hat.com>
Subject: Re: [PATCH] ubifs: Fix xattr generic handler usage

2016-07-31 21:42 GMT+02:00 Richard Weinberger <richard@....at>:
> UBIFS uses full names to work with xattrs, therefore we have to use
> xattr_full_name() to obtain the xattr prefix as string.
>
> Cc: <stable@...r.kernel.org>
> Cc: Andreas Gruenbacher <agruenba@...hat.com>
> Fixes: 2b88fc21ca ("ubifs: Switch to generic xattr handlers")
> Signed-off-by: Richard Weinberger <richard@....at>

Reviewed-by: Andreas Gruenbacher <agruenba@...hat.com>

> ---
>  fs/ubifs/xattr.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
> index b5fc279..c63710f 100644
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -575,7 +575,8 @@ static int ubifs_xattr_get(const struct xattr_handler *handler,
>         dbg_gen("xattr '%s', ino %lu ('%pd'), buf size %zd", name,
>                 inode->i_ino, dentry, size);
>
> -       return  __ubifs_getxattr(inode, name, buffer, size);
> +       name = xattr_full_name(handler, name);
> +       return __ubifs_getxattr(inode, name, buffer, size);
>  }
>
>  static int ubifs_xattr_set(const struct xattr_handler *handler,
> @@ -586,6 +587,8 @@ static int ubifs_xattr_set(const struct xattr_handler *handler,
>         dbg_gen("xattr '%s', host ino %lu ('%pd'), size %zd",
>                 name, inode->i_ino, dentry, size);
>
> +       name = xattr_full_name(handler, name);
> +
>         if (value)
>                 return __ubifs_setxattr(inode, name, value, size, flags);
>         else
> --
> 2.7.3
>