linux-kernel - Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3aca807-d81b-a7d0-aa8d-3077a54979aa@ti.com>
Date:	Mon, 1 Aug 2016 12:32:34 +0300
From:	Roger Quadros <rogerq@...com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	<linux-omap@...r.kernel.org>, Tony Lindgren <tony@...mide.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the
 function call "gpiochip_free_own_desc"

Hi Markus,

On 23/07/16 20:09, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 23 Jul 2016 18:54:02 +0200
> 
> The gpiochip_free_own_desc() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/memory/omap-gpmc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 869c83f..e138875 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2143,9 +2143,7 @@ err_child_fail:
>  	ret = -ENODEV;
>  
>  err_cs:
> -	if (waitpin_desc)
> -		gpiochip_free_own_desc(waitpin_desc);
> -
> +	gpiochip_free_own_desc(waitpin_desc);
>  err:
>  	gpmc_cs_free(cs);
>  
> 
This looks good to me. I will queue this for v4.8. Thanks.

cheers,
-roger