linux-kernel - Re: [PATCH v2 1/2] vfio : resume notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a21858d-29da-a1df-8938-d3a8caf77365@cn.fujitsu.com>
Date:	Mon, 1 Aug 2016 10:05:41 +0800
From:	Zhou Jie <zhoujie2011@...fujitsu.com>
To:	Alex Williamson <alex.williamson@...hat.com>
CC:	<linux-kernel@...r.kernel.org>, <qemu-devel@...gnu.org>,
	<izumi.taku@...fujitsu.com>, <fan.chen@...ystack.cn>,
	Chen Fan <chen.fan.fnst@...fujitsu.com>
Subject: Re: [PATCH v2 1/2] vfio : resume notifier

Hi, Alex

On 2016/7/30 1:11, Alex Williamson wrote:
> On Tue, 19 Jul 2016 15:52:45 +0800
> Zhou Jie <zhoujie2011@...fujitsu.com> wrote:
>
>> From: Chen Fan <chen.fan.fnst@...fujitsu.com>
>
> An empty commit log is unacceptable for all but the most trivial
> patches.
>
> There's also no sign-off on this patch.
Sorry. I should note it.

> I also don't know why we need this since you previously found that for
> QEMU, ordering of error versus resume notifications is not guaranteed,
> which is why I thought we went with a status flag within the struct
> vfio_device_info.  I'm not adding an interrupt to the user that has
> no users.  This was not part of the most recent discussion we had about
> this, so I'm lost why this patch exists. Thanks,
>
> Alex
I will remove the resume interrupt.

Sincerely
ZhouJie