linux-kernel - include/linux/cec-funcs.h:1280: suspicious expression ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 1 Aug 2016 11:24:45 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	hans.verkuil@...co.com, linux-media@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: include/linux/cec-funcs.h:1280: suspicious expression ?

Hello there,

include/linux/cec-funcs.h:1280:50: warning: logical ‘and’ applied to
non-boolean constant [-Wlogical-op]

Source code is

        msg->msg[4] = ui_cmd->channel_identifier.major && 0xff;

Maybe better code

        msg->msg[4] = ui_cmd->channel_identifier.major & 0xff;

Regards

David Binderman