linux-kernel - drivers/staging/ks7010/ks_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 1 Aug 2016 11:20:45 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	gregkh@...uxfoundation.org, wsa@...-dreams.de,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: drivers/staging/ks7010/ks_wlan_net.c:1287: suspicious if ?

Hello there,

drivers/staging/ks7010/ks_wlan_net.c:1287:13: warning: duplicated ‘if’
condition [-Wduplicated-cond]

Source code is

    } else if (enabled) {   /* 1 */
        if (priv->reg.operation_mode == MODE_INFRASTRUCTURE)
            priv->reg.powermgt = POWMGT_SAVE1_MODE;
        else
            return -EINVAL;
    } else if (enabled) {   /* 2 */

I am not sure of a suitable fix for this.

Regards

David Binderman