linux-kernel - Re: [PATCH 1/1] net: qlcnic: avoid superfluous assignement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=hENdsPG5u77N0vEnapSPmkJrLsPcXBUJ82s6msVX72sAi1g@mail.gmail.com>
Date:	Mon, 1 Aug 2016 10:57:20 +0800
From:	zhuyj <zyjzyj2000@...il.com>
To:	Heinrich Schuchardt <xypron.glpk@....de>
Cc:	Dept-GELinuxNICDev@...gic.com, netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] net: qlcnic: avoid superfluous assignement

Sorry.
An inline function will be inserted into the calling function. Why
"Assigning NULL to parmeter dcb has no effect outside of the
inlined function." ?

On Sun, Jul 31, 2016 at 6:07 PM, Heinrich Schuchardt <xypron.glpk@....de> wrote:
> Assigning NULL to parmeter dcb has no effect outside of the
> inlined function.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
> index 9777e57..f4aa633 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
> @@ -45,7 +45,6 @@ struct qlcnic_dcb {
>  static inline void qlcnic_clear_dcb_ops(struct qlcnic_dcb *dcb)
>  {
>         kfree(dcb);
> -       dcb = NULL;
>  }
>
>  static inline int qlcnic_dcb_get_hw_capability(struct qlcnic_dcb *dcb)
> --
> 2.8.1
>