linux-kernel - Re: [PATCH] xen: rename xen_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60e0cea0-cb2d-8398-49bc-fa06720453b7@oracle.com>
Date:	Mon, 1 Aug 2016 10:10:24 -0400
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org
Cc:	david.vrabel@...rix.com
Subject: Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

On 08/01/2016 07:40 AM, Juergen Gross wrote:
> There are two functions with name xen_pmu_init() in the kernel. Rename
> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
> arch/x86/xen/pmu.c
>
> Signed-off-by: Juergen Gross <jgross@...e.com>

While at it, how about changing xen_properties_init to
xen_sysfs_properties_init as well for consistency?

-boris

> ---
>  drivers/xen/sys-hypervisor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> index 6881b3c..17ea846 100644
> --- a/drivers/xen/sys-hypervisor.c
> +++ b/drivers/xen/sys-hypervisor.c
> @@ -455,7 +455,7 @@ static const struct attribute_group xen_pmu_group = {
>  	.attrs = xen_pmu_attrs,
>  };
>  
> -static int __init xen_pmu_init(void)
> +static int __init xen_sysfs_pmu_init(void)
>  {
>  	return sysfs_create_group(hypervisor_kobj, &xen_pmu_group);
>  }
> @@ -485,7 +485,7 @@ static int __init hyper_sysfs_init(void)
>  		goto prop_out;
>  #ifdef CONFIG_XEN_HAVE_VPMU
>  	if (xen_initial_domain()) {
> -		ret = xen_pmu_init();
> +		ret = xen_sysfs_pmu_init();
>  		if (ret) {
>  			sysfs_remove_group(hypervisor_kobj,
>  					   &xen_properties_group);