linux-kernel - Re: [PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160801150429.GD2542@mtj.duckdns.org>
Date:	Mon, 1 Aug 2016 11:04:29 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] silence warning in drivers/ata/libata-scsi.c when
 building W=1

On Sun, Jul 31, 2016 at 11:28:34PM -0400, Valdis Kletnieks wrote:
> When building with W=1, we get these warnings:
> 
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                        ~~~~~^~~~~~~~~
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                        ~~~~~^~~~~~~~~
> 
> So give them the extra () and make things a bit clearer for both the
> compiler and programmer...
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>

The offending commit got already reverted.

Thanks!

-- 
tejun