linux-kernel - Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Aug 2016 09:33:08 -0700
From:	Mike Waychison <mikew@...gle.com>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michel Lespinasse <walken@...gle.com>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the
 function call "dma_pool_destroy"

On Mon, Aug 1, 2016 at 5:04 AM, Matt Fleming <matt@...eblueprint.co.uk> wrote:
>
> On Sun, 24 Jul, at 10:27:49AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Sun, 24 Jul 2016 10:16:56 +0200
> >
> > The dma_pool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the call is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > ---
> >  drivers/firmware/google/gsmi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Looks fine to me. If Mike doesn't pick this up I'll take it through
> the EFI tree.

Yes please do.