linux-kernel - Re: warning: calling ‘__builtin_return_address’ with a nonzero argument is unsafe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFxSBGnnaMAFaG=rGxSQyArGZ8XDo6kPi3wsni=gmvsLKg@mail.gmail.com>
Date:	Mon, 1 Aug 2016 14:19:39 -0400
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: warning: calling ‘__builtin_return_address’ with a nonzero argument is unsafe

On Mon, Aug 1, 2016 at 2:10 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>>
>> It compiles for me, but I don't have a compiler that has that warning
>> to test with. See if this works. BTW, it looks like that last comma
>> before the ending parenthesis is not needed.
>
> Linus, did you get a chance to test this? I could send a formal patch
> if needed. I only have a 4.9 compiler, so I'm not seeing the warnings
> others have reported.

It seems to work for me. Warnings are still suppressed, and the
-Wno-frame-address flag seems to be nicely limited to just the build
of the kernel/trace/ subdirectory.

So feel free to add that patch to the tracing tree, with my tested-by.

           Linus