linux-kernel - Re: [PATCH v2] pstore: use DT reserved-memory bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+zMUpY6faHdcX_u46jS=vOgy=n09XczbKqdt_04guhAQ@mail.gmail.com>
Date:	Mon, 1 Aug 2016 13:19:48 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Rob Herring <robh+dt@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Greg Hackmann <ghackmann@...gle.com>
Subject: Re: [PATCH v2] pstore: use DT reserved-memory bindings

On Mon, Aug 1, 2016 at 12:58 PM, Rob Herring <robh+dt@...nel.org> wrote:
> On Mon, Aug 1, 2016 at 2:05 PM, Kees Cook <keescook@...omium.org> wrote:
>> Instead of a ramoops-specific node, use a child node of /reserved-memory.
>> This requires that of_platform_device_create() be explicitly called
>> for the node, though, since "/reserved-memory" does not have its own
>> "compatible" property.
>
> As I mentioned in my other reply, not strictly needed to find
> /reserved-memory node first, but it's fine either way.
>
> Acked-by: Rob Herring <robh@...nel.org>

Great! Thanks for helping aim me to the right place. :)

-Kees

>
>>
>> Suggested-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>> v2:
>> - rebase to 4.8, use of_platform_default_populate_init(), robh
>> - use platform device resources instead of node directly, robh
>> ---
>>  .../bindings/{misc => reserved-memory}/ramoops.txt |  8 ++---
>>  Documentation/ramoops.txt                          | 38 +++++++++++++++-------
>>  drivers/of/platform.c                              | 20 ++++++++++--
>>  fs/pstore/ram.c                                    | 23 ++++---------
>>  4 files changed, 56 insertions(+), 33 deletions(-)
>>  rename Documentation/devicetree/bindings/{misc => reserved-memory}/ramoops.txt (86%)



-- 
Kees Cook
Chrome OS & Brillo Security