linux-kernel - Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <579F9CDE.5050207@caviumnetworks.com>
Date:	Mon, 1 Aug 2016 12:02:54 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Jan Glauber <jglauber@...ium.com>, <linux-kernel@...r.kernel.org>,
	<linux-spi@...r.kernel.org>, David Daney <david.daney@...ium.com>,
	"Steven J . Hill" <steven.hill@...ium.com>
Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

On 08/01/2016 11:49 AM, Mark Brown wrote:
> On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote:
>> On 08/01/2016 10:28 AM, Mark Brown wrote:
>>> On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote:
>
>>>> +	p->clk = devm_clk_get(dev, NULL);
>>>> +	if (IS_ERR(p->clk))
>>>> +		goto out_unmap;
>
>>> We're now just using the normal clock API which is good but I'm now
>>> unclear what is going to ensure that the clock is there - is there some
>>> other change elsewhere that I'm not aware of?
>
>> The clock is an integral part of the SoC and is always running, so it will
>> always be there.  All we want to know is the frequency, which is supplied by
>> the device tree clock-bindings framework
>
> So there's something there that registers the clock?

Yes, when using OF device tree, standard device probing registers the clock.

> What is that thing on ACPI systems?

I don't know if it works ACPI, or if ACPI even has support for the clock 
framework.  But does it matter?  We are not currently using ACPI on 
systems where this driver is used.

In the future, if we ever need ACPI support, we will add support for it.

David.