linux-kernel - [PATCH 0/3] ASoC: remove snd_soc_pcm_set/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Aug 2016 06:07:37 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Linux-ALSA <alsa-devel@...a-project.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Simon <horms@...ge.net.au>, <linux-renesas-soc@...r.kernel.org>,
	Jie Yang <yang.jie@...ux.intel.com>,
	Takashi Iwai <tiwai@...e.com>,
	Patrick Lai <plai@...eaurora.org>,
	Banajit Goswami <bgoswami@...eaurora.org>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH 0/3] ASoC: remove snd_soc_pcm_set/get_drvdata()


Hi Mark

snd_soc_pcm_set_drvdata() will set driver data to rtd->dev,
but driver data of rtd->dev is already used as "rtd" on
soc_post_component_init().

	static int soc_post_component_init(xxx)
	{
		...
		dev_set_drvdata(rtd->dev, rtd);
		...
	}

But, ASoC has snd_soc_pcm_set/get_drvdata() to set rtd->dev.
It will overwrite existing data and will break system.
This patch tries to solve this issue.
Intel haswell and qcom is using these functions.

** Note **

I don't have these boards, thus, I did compile test only.

Kuninori Morimoto (3):
      ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()
      ASoC: lpass-platform: don't use snd_soc_pcm_set_drvdata()
      ASoC: remove snd_soc_pcm_set/get_drvdata()

 include/sound/soc.h                       | 11 -----------
 sound/soc/intel/haswell/sst-haswell-pcm.c |  1 -
 sound/soc/qcom/lpass-platform.c           | 14 +++++++-------
 sound/soc/qcom/lpass.h                    |  2 ++
 4 files changed, 9 insertions(+), 19 deletions(-)