linux-kernel - Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CA35E9E7-D9DC-4CF7-9C0B-3F3A314606DB@holtmann.org>
Date:	Tue, 2 Aug 2016 16:03:59 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Felipe Balbi <felipe.balbi@...ux.intel.com>
Cc:	Baole Ni <baolex.ni@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	m.chehab@...sung.com, Marek Szyprowski <m.szyprowski@...sung.com>,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	peter.chen@...escale.com, mina86@...a86.com,
	deepa.kernel@...il.com, mathias.nyman@...ux.intel.com,
	stern@...land.harvard.edu, chuansheng.liu@...el.com,
	oneukum@...e.com
Subject: Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro

Hi Felipe,

>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
>> 
>> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
>> Signed-off-by: Baole Ni <baolex.ni@...el.com>
>> ---
>> drivers/usb/misc/usbtest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
>> index 6b978f0..5e81dc3 100644
>> --- a/drivers/usb/misc/usbtest.c
>> +++ b/drivers/usb/misc/usbtest.c
>> @@ -15,7 +15,7 @@
>> /*-------------------------------------------------------------------------*/
>> 
>> static int override_alt = -1;
>> -module_param_named(alt, override_alt, int, 0644);
>> +module_param_named(alt, override_alt, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> 
> line too long. You need to run this series through scripts/checkpatch.pl

please don't give them any ideas. Next thing you know and another 1285 patch bomb is coming our way.

Regards

Marcel