linux-kernel - Re: [PATCH 0982/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1608021446350.2912@hadrien>
Date:	Tue, 2 Aug 2016 14:47:12 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Baole Ni <baolex.ni@...el.com>
cc:	gregkh@...uxfoundation.org, m.chehab@...sung.com,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, peter.senna@...il.com,
	akpm@...ux-foundation.org, luisbg@....samsung.com,
	Julia.Lawall@...6.fr, geliangtang@....com,
	colin.king@...onical.com, chuansheng.liu@...el.com,
	oneukum@...e.com
Subject: Re: [PATCH 0982/1285] Replace numeric parameter like 0444 with
 macro



On Tue, 2 Aug 2016, Baole Ni wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/usb/host/fotg210-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
> index 66efa9a..7ad395e 100644
> --- a/drivers/usb/host/fotg210-hcd.c
> +++ b/drivers/usb/host/fotg210-hcd.c
> @@ -4789,7 +4789,7 @@ out_unlock:
>  	return ret;
>  }
>
> -static DEVICE_ATTR(uframe_periodic_max, 0644, show_uframe_periodic_max,
> +static DEVICE_ATTR(uframe_periodic_max, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, show_uframe_periodic_max,

Over 80 chars.

julia

>  		   store_uframe_periodic_max);
>
>  static inline int create_sysfs_files(struct fotg210_hcd *fotg210)
> --
> 2.9.2
>
>