linux-kernel - Re: [RFC 0/4] tools lib traceevent: Install fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160802141411.GC6968@danjae.aot.lge.com>
Date:	Tue, 2 Aug 2016 23:14:11 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes

On Tue, Aug 02, 2016 at 04:01:44PM +0200, Jiri Olsa wrote:
> On Tue, Aug 02, 2016 at 09:48:23AM -0400, Steven Rostedt wrote:
> 
> SNIP
> 
> > > > 
> > > > 
> > > > Also I think it'd be better for libtraceevent has dependency to libdl
> > > > explicitly so that we can get rid of -ldl at the end.  
> > > 
> > > agreed, I'll queue your patch if v2 is needed
> > > 
> > 
> > BTW, before we start making this ready for their own libraries, I'd
> > like to make some changes with the naming convention. Mainly with
> > event_format and format_field.
> > 
> > Perhaps we should change them to pevent_event and pevent_field?
> 
> right, it does not have any global prefix for public symbols
> 
> I'd actualy expect something like 'traceevent_',
> but 'pevent' is ok as well I guess

The 'pevent' prefix would be more consistent to similar APIs IMHO.

Maybe it's worth splitting public header and internal header files?

Thanks,
Namhyung