linux-kernel - Re: [PATCH 0234/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57A09E20.5080103@roeck-us.net>
Date:	Tue, 2 Aug 2016 06:20:32 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Baole Ni <baolex.ni@...el.com>, jdelvare@...e.com
Cc:	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0234/1285] Replace numeric parameter like 0444 with macro

On 08/02/2016 03:51 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>   drivers/hwmon/abituguru.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
> index 7a09c16..84d7070 100644
> --- a/drivers/hwmon/abituguru.c
> +++ b/drivers/hwmon/abituguru.c
> @@ -194,7 +194,7 @@ MODULE_PARM_DESC(pwms, "Number of PWMs on the uGuru "
>
>   /* Default verbose is 2, since this driver is still in the testing phase */
>   static int verbose = 2;
> -module_param(verbose, int, 0644);
> +module_param(verbose, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

S_IRUGO is quite useful, such as in "S_IRUGO | S_IWUSR".

Note that I cut down the excessive Cc:. Please don't do that again,
and please submit a single patch for the hwmon subsystem.

Guenter