linux-kernel - Re: [PATCH v2] powerpc/32: fix csum_partial_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160802125104.GA13214@gate.crashing.org>
Date:	Tue, 2 Aug 2016 07:51:04 -0500
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Christophe Leroy <christophe.leroy@....fr>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Scott Wood <oss@...error.net>, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, stable@...r.kernel.org,
	antoine.blangy@....fr
Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

On Tue, Aug 02, 2016 at 10:07:05AM +0200, Christophe Leroy wrote:
> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()") introduced a bug when destination
> address is odd and initial csum is not null
> 
> In that (rare) case the initial csum value has to be rotated one byte
> as well as the resulting value is
> 
> This patch also fixes related comments
> 
> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()")
> Cc: stable@...r.kernel.org
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> ---
>  v2: updated comments as suggested by Segher

This looks good to me now, thanks,


Segher