linux-kernel - [PATCH 1063/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802121305.20985-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 20:13:05 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	jason.wessel@...driver.com, ccross@...roid.com,
	keescook@...omium.org, tony.luck@...el.com, tomi.valkeinen@...com,
	m.chehab@...sung.com, gregkh@...uxfoundation.org,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com
Cc:	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterz@...radead.org, rusty@...tcorp.com.au, jkosina@...e.cz,
	chuansheng.liu@...el.com, baolex.ni@...el.com
Subject: [PATCH 1063/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 kernel/debug/kdb/kdb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 2a20c0d..8c62a67 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -48,7 +48,7 @@
 #define	MODULE_PARAM_PREFIX "kdb."
 
 static int kdb_cmd_enabled = CONFIG_KDB_DEFAULT_ENABLE;
-module_param_named(cmd_enable, kdb_cmd_enabled, int, 0600);
+module_param_named(cmd_enable, kdb_cmd_enabled, int, S_IRUSR | S_IWUSR);
 
 char kdb_grep_string[KDB_GREP_STRLEN];
 int kdb_grepping_flag;
@@ -2183,7 +2183,7 @@ static int kdb_param_enable_nmi(const char *val, const struct kernel_param *kp)
 static const struct kernel_param_ops kdb_param_ops_enable_nmi = {
 	.set = kdb_param_enable_nmi,
 };
-module_param_cb(enable_nmi, &kdb_param_ops_enable_nmi, NULL, 0600);
+module_param_cb(enable_nmi, &kdb_param_ops_enable_nmi, NULL, S_IRUSR | S_IWUSR);
 
 /*
  * kdb_cpu - This function implements the 'cpu' command.
-- 
2.9.2