linux-kernel - Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc0c309b-1219-caab-b8fc-dd049f76f14d@lwfinger.net>
Date:	Tue, 2 Aug 2016 09:50:23 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Baole Ni <baolex.ni@...el.com>, konrad.wilk@...cle.com,
	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	jgross@...e.com, bhelgaas@...gle.com, m.chehab@...sung.com,
	pawel@...iak.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com
Cc:	chuansheng.liu@...el.com, linux-pcmcia@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro

On 08/02/2016 06:50 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>

I'm not sure how much these changes improve robustness and/or readability, but 
they cause no harm. For that reason, the changes in rtlwifi drivers is acked.

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> ---
>  drivers/pcmcia/cistpl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
> index 55ef7d1..ac6f619 100644
> --- a/drivers/pcmcia/cistpl.c
> +++ b/drivers/pcmcia/cistpl.c
> @@ -57,7 +57,7 @@ static const u_int exponent[] = {
>
>  /* 16-bit CIS? */
>  static int cis_width;
> -module_param(cis_width, int, 0444);
> +module_param(cis_width, int, S_IRUSR | S_IRGRP | S_IROTH);
>
>  void release_cis_mem(struct pcmcia_socket *s)
>  {
>