linux-kernel - Re: [PATCH 2/2] tools lib traceevent: Add str_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cgi5Kk8VdD=o9aCCu7AR=oCAS+xwEzMbO1PK=asRC_dkQ@mail.gmail.com>
Date:	Tue, 2 Aug 2016 23:27:27 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 2/2] tools lib traceevent: Add str_error_r()

On Tue, Aug 2, 2016 at 2:01 PM, Namhyung Kim <namhyung@...nel.org> wrote:
> The libtraceevent uses str_error_r() but its implementation is outside
> of the library.  So if an external program wants to link the
> libtraceevent it'd fail due to missing str_error_r.  Add it.

Please ignore this as it breaks perf build due to multiple definition. :-/

Thanks,
Namhyung


>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/lib/traceevent/Build | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/lib/traceevent/Build b/tools/lib/traceevent/Build
> index c681d0575d16..a4efdf7876ce 100644
> --- a/tools/lib/traceevent/Build
> +++ b/tools/lib/traceevent/Build
> @@ -4,6 +4,10 @@ libtraceevent-y += trace-seq.o
>  libtraceevent-y += parse-filter.o
>  libtraceevent-y += parse-utils.o
>  libtraceevent-y += kbuffer-parse.o
> +libtraceevent-y += str_error_r.o
> +
> +str_error_r.o: ../str_error_r.c
> +       $(call if_changed_dep,cc_o_c)
>
>  plugin_jbd2-y         += plugin_jbd2.o
>  plugin_hrtimer-y      += plugin_hrtimer.o
> --
> 2.9.2
>



-- 
Thanks,
Namhyung