linux-kernel - Re: [git pull] drm for v4.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87invjs6mu.fsf@intel.com>
Date:	Tue, 02 Aug 2016 15:22:01 +0300
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ville Syrjälä 
	<ville.syrjala@...ux.intel.com>
Cc:	Daniel Vetter <daniel.vetter@...el.com>,
	DRI mailing list <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm for v4.8

On Tue, 02 Aug 2016, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> On Tue, Aug 2, 2016 at 4:10 AM, Ville Syrjälä
> <ville.syrjala@...ux.intel.com> wrote:
>>
>> I have a couple of pending PSR patches you may want to try as well,
>> if i915.enable_psr=0 helps.
>
> Yes. i915.enable_psr=0 seems to make the bad flickering go away.
>
> I'll try your git trees out later, but what exactly changed with
> regards to psr lately? It's set as a "dangerous" option, and even just
> clearing it caused
>
>   Setting dangerous option enable_psr - tainting kernel
>
> which seems entirely bogus.

The warning comes from kernel/params.c for module_param_named_unsafe()
which has no way of knowing which values are safe, and complains if the
option is set at all.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center