linux-kernel - Re: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1470152655.18081.1.camel@redhat.com>
Date:	Tue, 02 Aug 2016 11:44:15 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Steve Wise <swise@...ngridcomputing.com>,
	"'Steven Rostedt'" <rostedt@...dmis.org>
Cc:	"'Baole Ni'" <baolex.ni@...el.com>, swise@...lsio.com,
	sean.hefty@...el.com, hal.rosenstock@...il.com, airlied@...ux.ie,
	kgene@...nel.org, k.kozlowski@...sung.com,
	dougthompson@...ssion.com, bp@...en8.de,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, hch@...radead.org, matanb@...lanox.com,
	markb@...lanox.com, jgunthorpe@...idianresearch.com,
	dean.luick@...el.com
Subject: Re: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro

On Tue, 2016-08-02 at 10:20 -0500, Steve Wise wrote:
> > 
> > 
> > On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote:
> > > 
> > > Acked-by: Steve Wise <swise@...ngridcomputing.com>
> > > 
> > 
> > I have to ask, why did you ack all these? There's several things
> > wrong with
> > this patch series, but even the point of the patch is mistaken. It
> > makes
> > readable code much less readable. When you chmod a file, do you
> > type
> > 
> >   chmod 0444 file
> > 
> > or do you write
> > 
> >   chmod S_IRUSR|S_IRGRP|S_IROTH file
> > 
> > ?
> > 
> > Which of the above is easier to figure what is being changed?
> > 
> 
> I assumed this was some global "fix up".   

It is, but I'm not so sure I don't agree with Steve.  I'm not sure this
actually makes things better.  At a minimum, I would argue that Bart's
fix is mandatory before they would get my ack.  I would also request
that even though the patches are split up for review, they be squashed
on commit (whoever would want to tackle this monstrous pile of dubious
janitorial stuff).

> > 
> > Not to mention, because the subject is the same for all 1285
> > patches, and you
> > deleted the content of the patch in your ack, there's no way to
> > know what
> > exactly this ack is for (I haven't received the original patch yet
> > because
> > it's probably being ratelimited by some mail server).
> > 
> 
> I acked just the single patches that hit cxgb3/cxgb4.  But if this is
> really
> garbage, then ignore my ACKs...
> 
> Steve.
> 

-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)