linux-kernel - Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ea8392e9-669c-6019-e149-f389fe8a14a3@suse.com>
Date:	Tue, 2 Aug 2016 09:12:04 +0200
From:	Juergen Gross <jgross@...e.com>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	david.vrabel@...rix.com, xen-devel@...ts.xenproject.org,
	boris.ostrovsky@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less
 scary

On 02/08/16 09:10, Jan Beulich wrote:
>>>> On 02.08.16 at 08:43, <JGross@...e.com> wrote:
>> --- a/arch/x86/xen/pmu.c
>> +++ b/arch/x86/xen/pmu.c
>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>>  	return;
>>  
>>  fail:
>> -	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> -		cpu, err);
>> +	if (err == -EOPNOTSUPP)
>> +		pr_info_once("VPMU disabled by hypervisor.\n");
>> +	else
>> +		pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> +			cpu, err);
> 
> I'm sorry for not already having thought about this for v1, but
> what about older hypervisors, where the hypercall would return
> -ENOSYS?

I wasn't aware of that possibility. It should be covered, of course!

V3 will be sent soon...

Thanks for noticing now,


Juergen