linux-kernel - Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737mns0qg.fsf@x220.int.ebiederm.org>
Date:	Tue, 02 Aug 2016 09:29:27 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Baole Ni <baolex.ni@...el.com>
Cc:	pablo@...filter.org, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
	davem@...emloft.net, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, johunt@...mai.com, vpai@...mai.com,
	chuansheng.liu@...el.com, aryabinin@...tuozzo.com
Subject: Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

Baole Ni <baolex.ni@...el.com> writes:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

*Scratches my head*  The permissions are not 0444 below.
With 1285 patches I wonder how many typos you may have made.

Was this generated by a script?

Eric

> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  net/netfilter/ipset/ip_set_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> index a748b0c..b6c060d3 100644
> --- a/net/netfilter/ipset/ip_set_core.c
> +++ b/net/netfilter/ipset/ip_set_core.c
> @@ -48,7 +48,7 @@ static inline struct ip_set_net *ip_set_pernet(struct net *net)
>  
>  static unsigned int max_sets;
>  
> -module_param(max_sets, int, 0600);
> +module_param(max_sets, int, S_IRUSR | S_IWUSR);
>  MODULE_PARM_DESC(max_sets, "maximal number of sets");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>");