linux-kernel - Re: [PATCH 0435/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKf9veNb720fQfviQeqbpk3uWa0KX0g5PPSaNMTc4018Q@mail.gmail.com>
Date:	Tue, 2 Aug 2016 09:07:30 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Baole Ni <baolex.ni@...el.com>,
	Greg KH <gregkh@...uxfoundation.org>
Cc:	mchehab@...nel.org, maurochehab@...il.com, mchehab@...radead.org,
	mchehab@...hat.com, Mauro Carvalho Chehab <m.chehab@...sung.com>,
	hverkuil@...all.nl, a.hajda@...sung.com,
	Borislav Petkov <bp@...en8.de>, linux-media@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, javier@....samsung.com,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	prabhakar.csengg@...il.com, chuansheng.liu@...el.com
Subject: Re: [PATCH 0435/1285] Replace numeric parameter like 0444 with macro

There are so many of these, I wonder if it'd be better to just do one
giant patch, or at least break them up by subsystem instead of by
individual source file...

-Kees

On Tue, Aug 2, 2016 at 4:11 AM, Baole Ni <baolex.ni@...el.com> wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/media/i2c/tvp5150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 0b6d46c..d8ffd88 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -33,7 +33,7 @@ MODULE_LICENSE("GPL");
>
>
>  static int debug;
> -module_param(debug, int, 0644);
> +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(debug, "Debug level (0-2)");
>
>  struct tvp5150 {
> --
> 2.9.2
>



-- 
Kees Cook
Chrome OS & Brillo Security