linux-kernel - Re: [PATCH] staging: comedi/drivers: Fixed sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4034f9ed-d1bc-eb42-02f1-231e6a0b8074@mev.co.uk>
Date:	Tue, 2 Aug 2016 17:41:45 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Nayeemahmed Badebade <itachi.opsrc@...il.com>,
	hsweeten@...ionengravers.com
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi/drivers: Fixed sparse warnings

On 30/07/16 17:38, Nayeemahmed Badebade wrote:
> Fixed below sparse warnings in dt2811.c
>  warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
>  warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
>
> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@...il.com>
> ---
>  drivers/staging/comedi/drivers/dt2811.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
> index 904f6377..07f99c0 100644
> --- a/drivers/staging/comedi/drivers/dt2811.c
> +++ b/drivers/staging/comedi/drivers/dt2811.c
> @@ -96,11 +96,11 @@
>   *    6      6      100 kHz	 6   1000000
>   *    7     12       50 kHz	 7   10000000
>   */
> -const unsigned int dt2811_clk_dividers[] = {
> +static const unsigned int dt2811_clk_dividers[] = {
>  	1, 10, 2, 3, 4, 5, 6, 12
>  };
>
> -const unsigned int dt2811_clk_multipliers[] = {
> +static const unsigned int dt2811_clk_multipliers[] = {
>  	1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
>  };
>
> --
> 1.9.1
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-