linux-kernel - Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802134634.GA26043@kroah.com>
Date:	Tue, 2 Aug 2016 15:46:34 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Matwey V. Kornilov" <matwey@....msu.ru>
Cc:	Baole Ni <baolex.ni@...el.com>, Jiri Slaby <jslaby@...e.com>,
	m.chehab@...sung.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	linux-serial@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	andriy.shevchenko@...ux.intel.com, phillip.raffeck@....de,
	anton.wuerfel@....de, Peter Hurley <peter@...leysoftware.com>,
	yamada.masahiro@...ionext.com,
	wan.ahmad.zainie.wan.mohamad@...el.com, mail@...iej.szmigiero.name,
	chuansheng.liu@...el.com
Subject: Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 02, 2016 at 04:34:20PM +0300, Matwey V. Kornilov wrote:
> And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH  can be simplified
> to S_IRUGO | S_IWUSR, not?
> I think we need to have and use dedicated special macros for most
> common magic octal permissions like 0755 or 0644.

We already do have them, the developer here decided to not use them for
some unknown reason, making all 1285 of these patches wrong :(