linux-kernel - Re: [PATCH 0505/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802165304.dbok2ekhijtdbqqp@pirotess.bf.iodev.co.uk>
Date:	Tue, 2 Aug 2016 13:53:05 -0300
From:	Ismael Luceno <ismael@...ev.co.uk>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	mchehab@...nel.org, andrey.utkin@...p.bluecherry.net, bp@...en8.de,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, jh1009.sung@...sung.com,
	nenggun.kim@...sung.com, hdegoede@...hat.com
Subject: Re: [PATCH 0505/1285] Replace numeric parameter like 0444 with macro

On 02/Ago/2016 19:18, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

That's very subjective; I don't agree.

IMO numbers are better in this context.