linux-kernel - Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb4e3c33-b2d3-00f3-3f2d-dcc4a641d53f@cumulusnetworks.com>
Date:	Tue, 2 Aug 2016 11:09:04 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	John Stultz <john.stultz@...aro.org>,
	Lorenzo Colitti <lorenzo@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Mateusz Bajorski <mateusz.bajorski@...ia.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Guodong Xu <guodong.xu@...aro.org>,
	Dmitry Shmidt <dimitrysh@...gle.com>,
	Chih-Hung Hsieh <chh@...gle.com>,
	Eric Caruso <ejcaruso@...gle.com>
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to
 fib_nl_newrule breaks Android userspace

On 8/2/16 11:03 AM, John Stultz wrote:
> So bisecting between v4.7 and linus/HEAD with the test above, it seems like:
> 96c63fa7393d ("net: Add l3mdev rule")  is what breaks the tests.
>
> The l3mdev rule patch is a bit tangled with the fib_rules one, but if
> I revert both of those, the only thing that fails is the
> ./neighbour_test.py (which I need to dig further into). But those two
> changes seem to be connected to the regression I'm seeing with
> Android.
That is surprising since the l3mdev rule should not exist on Android 
unless it has created a VRF.

Does Android have custom FRA types in <linux/fib_rules.h>? Perhaps there 
is a collision on attribute number?